simd op check: Do not include the scalar version and error checking code in the code that will be used to scan for the instruction.#9007
Merged
mcourteaux merged 1 commit intohalide:mainfrom Mar 15, 2026
Conversation
mcourteaux
changed the title
Contributor
Author
|
@alexreinking the windows failure seems like a CI configuration issue? |
Member
|
No, this is a random feature-detection failure. There's some x86 chip that we mis-detect. Too bad this workflow didn't print CPU details (but then there's no /proc/cpuinfo there) |
… that will be used to find the intrinsic.
mcourteaux
force-pushed
the
fix-simd-op-check
branch
from
b2f25dd to
34c3b0d
Compare
alexreinking
approved these changes
Mar 14, 2026
mcourteaux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, we get false positive test result when the scalar version or error checking code is generating the instruction we're after.
Found one such case on x86 (
korw). I'll let the buildbots figure out if there is more instances.